[Reference] field dependent empty_data option description #4083
Conversation
|
I updated #4033 to use a placeholder together with the |
| required and left empty by the user. | ||
|
|
||
| The true default value of this option depends on other field options: | ||
| DEFAULT_PLACEHOLDER |
There was a problem hiding this comment.
I think we might be able to put a comment above this, to explain its purpose (I'm not sure if the multi-line comment works like this):
.. This file should only be included with start-after or end-before that's set to
this DEFAULT_PLACEHOLDER value. Its purpose is to let us include only part of this file.There was a problem hiding this comment.
Thanks for the suggestion. It's really nice. Though we can't use DEFAULT_PLACEHOLDER as is in the comment. But that's not a major issue.
|
@xabbuh You said this is not yet complete, what else do you want to do? You also said that you're not sure if you like the way it looks now with the default value below the Thanks! |
Oh, it's complete now. I forgot to remove that note.
That was before I introduced the placeholder. The description of the real default value was that split with an example of when this might be useful. Now, we have the description of the default value first, followed by the example. I think it's fine this way. |
|
Ok, let's see if this renders how we expect :). Thanks Christian! |
…xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [Reference] field dependent empty_data option description | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | #4007 - [x] choice - [x] collection - [x] country - [x] currency - [x] email - [x] entity - [x] file - [x] form - [x] integer - [x] language - [x] locale - [x] money - [x] number - [x] password - [x] percent - [x] radio - [x] search - [x] text - [x] textarea - [x] timezone - [x] url Replacement of #4033. Commits ------- 6b61260 field dependent empty_data option description
|
Thanks, Ryan! I think it looks good so far. |
Replacement of #4033.